Reviewers: Igor Sheludko,
Description:
Revert the (wrong) fix of the argument index check asserion.
R=ish...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/208423017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -21 lines):
M src/x64/lithium-codegen-x64.cc
D test/mjsunit/regress/regress-355486.js
Index: test/mjsunit/regress/regress-355486.js
diff --git a/test/mjsunit/regress/regress-355486.js
b/test/mjsunit/regress/regress-355486.js
deleted file mode 100644
index
55362a13416335b72bfa1ff92bc29f7a04edbd65..0000000000000000000000000000000000000000
--- a/test/mjsunit/regress/regress-355486.js
+++ /dev/null
@@ -1,13 +0,0 @@
-// Copyright 2014 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Flags: --allow-natives-syntax
-
-function f() { var v = arguments[0]; }
-function g() { f(); }
-
-g();
-g();
-%OptimizeFunctionOnNextCall(g);
-g();
Index: src/x64/lithium-codegen-x64.cc
diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc
index
401a49e6b1121cfb866d2c86249a83b9e017e3b9..a6be27140ce546cfb5ae82e4a4d56d22f376daba
100644
--- a/src/x64/lithium-codegen-x64.cc
+++ b/src/x64/lithium-codegen-x64.cc
@@ -2910,14 +2910,9 @@ void
LCodeGen::DoAccessArgumentsAt(LAccessArgumentsAt* instr) {
instr->index()->IsConstantOperand()) {
int32_t const_index =
ToInteger32(LConstantOperand::cast(instr->index()));
int32_t const_length =
ToInteger32(LConstantOperand::cast(instr->length()));
- if (const_index < const_length) {
- StackArgumentsAccessor args(arguments, const_length,
- ARGUMENTS_DONT_CONTAIN_RECEIVER);
- __ movp(result, args.GetArgumentOperand(const_index));
- } else {
- // This code should never be executed; just stop here.
- __ int3();
- }
+ StackArgumentsAccessor args(arguments, const_length,
+ ARGUMENTS_DONT_CONTAIN_RECEIVER);
+ __ movp(result, args.GetArgumentOperand(const_index));
} else {
Register length = ToRegister(instr->length());
// There are two words between the frame pointer and the last argument.
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
