LGTM
https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc#newcode3913
test/cctest/test-heap.cc:3913: // We should have ran into an out of
memory.
nit: s/ran/run/
https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc#newcode3914
test/cctest/test-heap.cc:3914: UNREACHABLE();
Use CHECK(false) here so it does something in Release mode too.
https://codereview.chromium.org/213193011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
