On 2014/03/24 13:17:11, ulan (offline till April 1) wrote:
On 2014/03/24 12:52:35, rmcilroy wrote:
> Ulan: Unfortunately your suggestion of simply not marking heap entries
in
the
> Constant Pool didn't work because the VerifyMarking object visitor would
> complain that some object's weren't marked. I've changed approach and
now
> simply mark whether the constant pool is for optimized code and do the
> appropriate checks in object visitor. PTAL.
Interesting! Could you give me command lines that reproduce the failure?
This approach looks good. I have two suggestions:
- instead of bool is_optimized please use an enum because soon IC stubs
will
have weak maps too.
- instead of passing the flag through heap and factory allocation
functions,
allocate the constant pool with a default flag value that visits all
references,
and then update the flag in the constant pool to the correct value in
LCodeGenBase::RegisterWeakObjectsInOptimizedCode.
Good suggestions, thanks Ulan. I've uploaded a new patch set with these
suggestions. PTAL.
https://codereview.chromium.org/209473006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
