Reviewers: ulan (offline till April 1), alph,
Description:
NativeContext::map_cache reference should be strong in heap snapshots
This change makes the reference itself a strong one. We will also need a
special
handling to make references from MapCache object to Map weak in the heap
snapshots. The latter will be addressed separately.
BUG=chromium:357060
Please review this at https://codereview.chromium.org/214683002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/heap-snapshot-generator.cc
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index
10e177d4f0ecf8425a249d91b2b528af285d0089..332d0dbf6ff3705318f28a666d7134667e12295c
100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -1278,7 +1278,8 @@ void V8HeapExplorer::ExtractContextReferences(int
entry, Context* context) {
}
#define EXTRACT_CONTEXT_FIELD(index, type, name) \
- if (Context::index < Context::FIRST_WEAK_SLOT) { \
+ if (Context::index < Context::FIRST_WEAK_SLOT || \
+ Context::index == Context::MAP_CACHE_INDEX) { \
SetInternalReference(context, entry, #name,
context->get(Context::index), \
FixedArray::OffsetOfElementAt(Context::index)); \
} else { \
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
