https://codereview.chromium.org/212603013/diff/1/src/handles-inl.h
File src/handles-inl.h (right):
https://codereview.chromium.org/212603013/diff/1/src/handles-inl.h#newcode61
src/handles-inl.h:61: if (location_ == NULL || other.location_ == NULL)
return false;
I guess you moved that code to have the asserts in the beginning of the
function?
https://codereview.chromium.org/212603013/diff/1/src/hydrogen-environment-liveness.cc
File src/hydrogen-environment-liveness.cc (right):
https://codereview.chromium.org/212603013/diff/1/src/hydrogen-environment-liveness.cc#newcode236
src/hydrogen-environment-liveness.cc:236: Heap::RelocationLock
for_heap_access(isolate()->heap());
what about moving that locking code to where it is needed, i.e.
ZapEnvironmentSlotsForInstruction?
https://codereview.chromium.org/212603013/diff/1/src/hydrogen-environment-liveness.cc#newcode244
src/hydrogen-environment-liveness.cc:244: Heap::RelocationLock
for_heap_access(isolate()->heap());
what about moving that locking code to where it is needed, i.e.
ZapEnvironmentSlotsInSuccessors?
https://codereview.chromium.org/212603013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
