https://codereview.chromium.org/202293004/diff/160001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/202293004/diff/160001/src/objects.cc#newcode15903
src/objects.cc:15903: capacity = Max(kMinCapacity, capacity);
Can be an assert instead? I don't think this needs to be a runtime
check.

https://codereview.chromium.org/202293004/diff/160001/src/objects.cc#newcode15929
src/objects.cc:15929: // Don't need to grow if we can simply clear out
deleted entries instead.
This comment does not look accurate. We still call Allocate.

We should probably add a Compact function that does the in place
cleanup.

https://codereview.chromium.org/202293004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to