Reviewers: Yang, loislo,
Description:
Remove debugger_auto_break flag
The flag was introduced to support console debugger in Chrome. That
debugger was
replaced by DevTools long time ago and the flag is always true now.
BUG=None
LOG=Y
Please review this at https://codereview.chromium.org/220743003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -14 lines):
M include/v8-debug.h
M src/execution.cc
M src/flag-definitions.h
M test/cctest/test-debug.cc
Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index
1a86a061e9027dc33030c026c5d5c87acddee92a..0199cd2a01fcfaef3a986defd1837da0ca4d7026
100644
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -290,7 +290,7 @@ class V8_EXPORT Debug {
*
* Generally when message arrives V8 may be in one of 3 states:
* 1. V8 is running script; V8 will automatically interrupt and process
all
- * pending messages (however auto_break flag should be enabled);
+ * pending messages;
* 2. V8 is suspended on debug breakpoint; in this state V8 is dedicated
* to reading and processing debug messages;
* 3. V8 is not running at all or has called some long-working C++
function;
Index: src/execution.cc
diff --git a/src/execution.cc b/src/execution.cc
index
da07d0f707d6c5c93eb88eb16dc3c775434ad92f..2e164139c801e91a01c417a9e0b88dd0a60b8f50
100644
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -519,11 +519,9 @@ bool StackGuard::IsDebugCommand() {
void StackGuard::DebugCommand() {
- if (FLAG_debugger_auto_break) {
- ExecutionAccess access(isolate_);
- thread_local_.interrupt_flags_ |= DEBUGCOMMAND;
- set_interrupt_limits(access);
- }
+ ExecutionAccess access(isolate_);
+ thread_local_.interrupt_flags_ |= DEBUGCOMMAND;
+ set_interrupt_limits(access);
}
#endif
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
3f0f7ec4fe1dd3b42fa236f63c10c41ec8706b17..f3eaac8377b2ab59fc758040e3f4ce3d5336a628
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -471,9 +471,6 @@ DEFINE_bool(trace_array_abuse, false,
"trace out-of-bounds accesses to all arrays")
DEFINE_implication(trace_array_abuse, trace_js_array_abuse)
DEFINE_implication(trace_array_abuse, trace_external_array_abuse)
-DEFINE_bool(debugger_auto_break, true,
- "automatically set the debug break flag when debugger commands
are "
- "in the queue")
DEFINE_bool(enable_liveedit, true, "enable liveedit experimental feature")
DEFINE_bool(hard_abort, true, "abort by crashing")
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index
b51cb77246f91fb8ed64d2d0342cb15c01c31dbe..bf3e223709679a783fb904d9fbf063375f0cf2c6
100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -5409,8 +5409,6 @@ void BreakpointsDebuggerThread::Run() {
void TestRecursiveBreakpointsGeneric(bool global_evaluate) {
- i::FLAG_debugger_auto_break = true;
-
BreakpointsDebuggerThread breakpoints_debugger_thread(global_evaluate);
BreakpointsV8Thread breakpoints_v8_thread;
@@ -5881,7 +5879,6 @@ void HostDispatchDebuggerThread::Run() {
TEST(DebuggerHostDispatch) {
HostDispatchDebuggerThread host_dispatch_debugger_thread;
HostDispatchV8Thread host_dispatch_v8_thread;
- i::FLAG_debugger_auto_break = true;
// Create a V8 environment
Barriers stack_allocated_host_dispatch_barriers;
@@ -5948,8 +5945,6 @@ TEST(DebuggerDebugMessageDispatch) {
DebugMessageDispatchDebuggerThread
debug_message_dispatch_debugger_thread;
DebugMessageDispatchV8Thread debug_message_dispatch_v8_thread;
- i::FLAG_debugger_auto_break = true;
-
// Create a V8 environment
Barriers stack_allocated_debug_message_dispatch_barriers;
debug_message_dispatch_barriers =
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
