Reviewers: ulan, jochen,
Description:
ARM64: Fix cctest/test-disasm-arm64/debug on real hardware.
Without the 'BREAK' parameter, no instruction is generated when we are not
running with the simulator.
Please review this at https://codereview.chromium.org/221903004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -7 lines):
M test/cctest/test-disasm-arm64.cc
Index: test/cctest/test-disasm-arm64.cc
diff --git a/test/cctest/test-disasm-arm64.cc
b/test/cctest/test-disasm-arm64.cc
index
3343175e9362ae07176c16b14088525798c4191e..23f7b6daf26a7c9d551aa84a9e0d5282406df3fb
100644
--- a/test/cctest/test-disasm-arm64.cc
+++ b/test/cctest/test-disasm-arm64.cc
@@ -1605,13 +1605,13 @@ TEST_(debug) {
// All debug codes should produce the same instruction, and the debug
code
// can be any uint32_t.
- COMPARE(debug("message", 0, NO_PARAM), "hlt #0xdeb0");
- COMPARE(debug("message", 1, NO_PARAM), "hlt #0xdeb0");
- COMPARE(debug("message", 0xffff, NO_PARAM), "hlt #0xdeb0");
- COMPARE(debug("message", 0x10000, NO_PARAM), "hlt #0xdeb0");
- COMPARE(debug("message", 0x7fffffff, NO_PARAM), "hlt #0xdeb0");
- COMPARE(debug("message", 0x80000000u, NO_PARAM), "hlt #0xdeb0");
- COMPARE(debug("message", 0xffffffffu, NO_PARAM), "hlt #0xdeb0");
+ COMPARE(debug("message", 0, BREAK), "hlt #0xdeb0");
+ COMPARE(debug("message", 1, BREAK), "hlt #0xdeb0");
+ COMPARE(debug("message", 0xffff, BREAK), "hlt #0xdeb0");
+ COMPARE(debug("message", 0x10000, BREAK), "hlt #0xdeb0");
+ COMPARE(debug("message", 0x7fffffff, BREAK), "hlt #0xdeb0");
+ COMPARE(debug("message", 0x80000000u, BREAK), "hlt #0xdeb0");
+ COMPARE(debug("message", 0xffffffffu, BREAK), "hlt #0xdeb0");
CLEANUP();
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
