On 2014/04/03 15:17:06, Igor Sheludko wrote:
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
src/builtins.cc:399: Handle<FixedArrayBase> elms_obj =
maybe_elms_obj.ToHandleChecked();
On 2014/04/03 15:04:04, Yang wrote:
> That would be a duplicate check. Why not use ToHandle in the
if-condition
and
> convert at the same time.
> Same below.
Good point, done.
lgtm.
https://codereview.chromium.org/223743003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.