thanks for review!
https://codereview.chromium.org/225743002/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/225743002/diff/40001/src/parser.h#newcode120
src/parser.h:120: if (functions_size < 0) return 0;
On 2014/04/04 12:10:59, ulan wrote:
Shouldn't these checks be ASSERTs instead?
What does it mean if the size is negative or not a multiple of the
entry size?
It's just invalid data then. The length field is tells how many ints we
have which describe the function data, and each function takes
FunctionEntry::kSize ints. So if the length is not non-negative multiple
of FunctionEntry::kSize, the data is wrong.
https://codereview.chromium.org/225743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
