https://codereview.chromium.org/225703002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):

https://codereview.chromium.org/225703002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode2153
src/arm64/lithium-codegen-arm64.cc:2153: }
On 2014/04/04 12:04:13, ulan wrote:
Instead of checking for map_set.size() == 1, how about always doing
this
optimization for the last element of the map_set?

Something along the lines:

ASSERT(map_set.size() > 0);
int i = 0;
for (; i + 1 < map_set.size(); i++) {
    ...
    __ B(eq, &success);
}
Handle<Map> map = map_set.at(i).handle();
__ CompareMap(map_reg, map);
deoptimize if ne

Done.

https://codereview.chromium.org/225703002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to