lgtm
https://codereview.chromium.org/222433002/diff/20001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/222433002/diff/20001/src/arm64/macro-assembler-arm64.cc#newcode622
src/arm64/macro-assembler-arm64.cc:622: int min_adr_offset = -1 <<
(Instruction::ImmPCRelRangeBitwidth - 1);
Please use -(1 << (Instruction::ImmPCRelRangeBitwidth - 1)) to make it
clear. Left shifting a negative number is undefined in C++.
https://codereview.chromium.org/222433002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
