https://codereview.chromium.org/228263005/diff/20001/src/types.h
File src/types.h (right):
https://codereview.chromium.org/228263005/diff/20001/src/types.h#newcode301
src/types.h:301: ClassType* AsClass() { return ClassType::cast(this); }
On 2014/04/09 05:33:14, Benedikt Meurer wrote:
I really dislike this change. AsClass() and AsConstant() is already
somewhat
cumbersome, but adding another level of indirection there makes it
even worse,
esp. since ClassType and ConstantType do not provide any additional
value in the
public API.
Let's chat about this offline...
As discussed offline, I prefer the consistency. It's not used often
enough to make taking short cuts necessary.
https://codereview.chromium.org/228263005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
