Reviewers: danno, jarin, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Make new space iterable when transitioning double array to objects.
Port r20603 (a8e7478)
BUG=
Please review this at https://codereview.chromium.org/230243004/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+11, -2 lines):
M src/mips/codegen-mips.cc
Index: src/mips/codegen-mips.cc
diff --git a/src/mips/codegen-mips.cc b/src/mips/codegen-mips.cc
index
1b79433d3760ca1cadbde60c17fee339480e4bb2..219f4241abaf97cb2d715a6e2aee0f747237d1de
100644
--- a/src/mips/codegen-mips.cc
+++ b/src/mips/codegen-mips.cc
@@ -744,7 +744,7 @@ void
ElementsTransitionGenerator::GenerateDoubleToObject(
// -- a3 : target map, scratch for subsequent call
// -- t0 : scratch (elements)
// -----------------------------------
- Label entry, loop, convert_hole, gc_required, only_change_map;
+ Label entry, loop, convert_hole, gc_required, gc_cleanup,
only_change_map;
if (mode == TRACK_ALLOCATION_SITE) {
__ JumpIfJSArrayHasAllocationMemento(a2, t0, fail);
@@ -789,6 +789,15 @@ void
ElementsTransitionGenerator::GenerateDoubleToObject(
// t5: heap number map
__ Branch(&entry);
+ __ bind(&gc_cleanup);
+#ifdef VERIFY_HEAP
+ // Make sure new space is iterable if we are verifying the heap.
+ __ li(a0, Operand(masm->isolate()->factory()->one_pointer_filler_map()));
+ __ sw(a0, MemOperand(a3));
+ __ Addu(a3, a3, kPointerSize);
+ __ Branch(&gc_cleanup, lt, a3, Operand(t1));
+#endif
+
// Call into runtime if GC is required.
__ bind(&gc_required);
__ MultiPop(a0.bit() | a1.bit() | a2.bit() | a3.bit() | ra.bit());
@@ -803,7 +812,7 @@ void
ElementsTransitionGenerator::GenerateDoubleToObject(
__ Branch(&convert_hole, eq, a1, Operand(kHoleNanUpper32));
// Non-hole double, copy value into a heap number.
- __ AllocateHeapNumber(a2, a0, t6, t5, &gc_required);
+ __ AllocateHeapNumber(a2, a0, t6, t5, &gc_cleanup);
// a2: new heap number
__ lw(a0, MemOperand(t0, -12));
__ sw(a0, FieldMemOperand(a2, HeapNumber::kMantissaOffset));
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
