lgtm with nits:
https://codereview.chromium.org/237143004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4423
src/objects.cc:4423: Isolate* isolate = cache->GetIsolate();
While we are here: lets get isolate only once in this method.
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4461
src/objects.cc:4461: Handle<Map> map(object->map());
While we are here: map(..., isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4474
src/objects.cc:4474: Handle<DescriptorArray>
descs(map->instance_descriptors());
, isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4474
src/objects.cc:4474: Handle<DescriptorArray>
descs(map->instance_descriptors());
, isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4479
src/objects.cc:4479: Handle<Name> key(descs->GetKey(i));
, isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4487
src/objects.cc:4487: Handle<Name> key(descs->GetKey(i));
, isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4496
src/objects.cc:4496: Handle<Name> key(descs->GetKey(i));
, isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4517
src/objects.cc:4517:
isolate->context()->native_context()->normalized_map_cache());
, isolate)
https://codereview.chromium.org/237143004/diff/1/src/objects.cc#newcode4519
src/objects.cc:4519: cache, handle(object->map()), mode);
handle(..., isolate)
https://codereview.chromium.org/237143004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
