lgtm with nits:
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc#oldcode1887
src/objects.cc:1887: TransitionFlag flag = attributes != NONE ?
OMIT_TRANSITION : initial_flag;
This code is lost.
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc#newcode1846
src/objects.cc:1846: if (!name->IsCacheable(isolate)) return
Handle<Map>();
MaybeHandle<>
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc#newcode1852
src/objects.cc:1852: representation = Representation::Tagged();
Shouldn't we update type here as well?
https://codereview.chromium.org/238543005/diff/90001/src/objects.cc#newcode1898
src/objects.cc:1898: } else {
I think you can now write here:
} else if (!object->TooManyFastProperties(..)) {
and remove the elseif above.
https://codereview.chromium.org/238543005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
