https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc
File src/parser-thread.cc (right):

https://codereview.chromium.org/214883002/diff/690001/src/parser-thread.cc#newcode94
src/parser-thread.cc:94: preparser.set_allow_lazy(true);
On 2014/04/23 10:18:20, ulan wrote:
Would it be worthwhile to put these flags into a separate struct that
can be
copied? Then this code would look like
params_.allow_lazy = true;
preparser.set_params(params_);

In other places you would need to pass one struct instead of passing
each flag
indiviually.

+1 for this proposal, see
http://refactoring.com/catalog/introduceParameterObject.html

https://codereview.chromium.org/214883002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to