https://codereview.chromium.org/249183003/diff/1/src/base/macros.h
File src/base/macros.h (right):

https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode31
src/base/macros.h:31: #include "../../include/v8stdint.h"
On 2014/04/23 11:38:35, Sven Panne wrote:
Just a note: I think we have to reconsider our include paths a bit
when this is
a real library. Relative paths leaving the library won't work then...

Yes

https://codereview.chromium.org/249183003/diff/1/src/base/macros.h#newcode50
src/base/macros.h:50: static_cast<size_t>(!(sizeof(a) % sizeof(*(a)))))
On 2014/04/23 11:38:35, Sven Panne wrote:
This has been here before, but anyway: The divisor seems to be some
kind of
safeguard, but when exactly should it trigger? Either add an example
or remove
it.

See
https://code.google.com/p/chromium/codesearch#chromium/src/base/macros.h&l=107

https://codereview.chromium.org/249183003/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to