https://codereview.chromium.org/245963007/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/245963007/diff/20001/src/objects.h#newcode1680
src/objects.h:1680: // 01 NOT_FOUND
On 2014/04/23 14:34:52, Michael Starzinger wrote:
nit: This NOT_FOUND constant doesn't seem to exist, can we drop it
from the
comment?
This was there in the first patch set. Forgot to remove. Done.
https://codereview.chromium.org/245963007/diff/20001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode1725
src/spaces.h:1725: // in this space, or Failure::Exception() if it is
not. The implementation
On 2014/04/23 14:34:52, Michael Starzinger wrote:
Comment is outdated.
Done.
https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode1728
src/spaces.h:1728: MUST_USE_RESULT Object* FindObject(Address addr);
On 2014/04/23 14:34:52, Michael Starzinger wrote:
nit: I think the MUST_USE_RESULT is overzealous here.
Done.
https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode2844
src/spaces.h:2844: // Finds an object for a given address, returns
Failure::Exception()
On 2014/04/23 14:34:52, Michael Starzinger wrote:
Comment is outdated.
Done.
https://codereview.chromium.org/245963007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
