[v8-dev] Re: Issue 3274 in v8: PropertyCallbackInfo.This() should return Local instead of Local

Fri, 25 Apr 2014 01:41:26 -0700


Comment #6 on issue 3274 by yang...@chromium.org: PropertyCallbackInfo.This() should return Local<Value> instead of Local<Object>
http://code.google.com/p/v8/issues/detail?id=3274

I updated the CL so that V8 compiles. Chrome still fails due to a failure in the generated gen/blink/bindings/V8Window.cpp:

../../v8/include/v8.h: In constructor 'v8::Handle<T>::Handle(v8::Handle<S>) [with S = v8::Value, T = v8::Object]':
gen/blink/bindings/V8Window.cpp:7312:78:   instantiated from here

That line still uses v8::Object instead of v8::Value.

V8HiddenValue::setHiddenValue(isolate, v8::Handle<v8::Object>(info.This()), name, v8Value);

v8::Object::SetHiddenValue takes v8::Handle<v8::Value> as argument, so that part is already alright.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to