addressed comments.
https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js#newcode1212
src/mirror-debugger.js:1212: return this.promise_;
On 2014/04/25 13:38:25, aandrey wrote:
did you mean this.value_ ?
Nice catch. I removed this so that .value() returns the value, like is
the case for other mirror types as well. And I added a check in the test
case.
https://codereview.chromium.org/257803005/diff/1/src/mirror-debugger.js#newcode1216
src/mirror-debugger.js:1216: PromiseMirror.Pending = 0;
On 2014/04/25 13:29:45, rossberg wrote:
Instead of defining these constants, the status function should
convert the
internal ints into descriptive strings.
Done.
https://codereview.chromium.org/257803005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
