Hi Yutaka, seems like the committee flipped its decision back to the
original
semantics due to legacy issues. So we should land this CL. But please see my
comments. Also, there should probably be a test for this in
harmony/promises.js
(maybe there is by now).
https://codereview.chromium.org/180723011/diff/60001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/180723011/diff/60001/src/promise.js#newcode152
src/promise.js:152: typeof onResolve === 'function' ? onResolve :
PromiseIdResolveHandler;
We shouldn't change .chain, only .then
https://codereview.chromium.org/180723011/diff/60001/src/promise.js#newcode206
src/promise.js:206: typeof onResolve === 'function' ? onResolve :
PromiseIdResolveHandler;
Please use the IS_SPEC_FUNCTION macro instead.
https://codereview.chromium.org/180723011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
