https://codereview.chromium.org/254433002/diff/20001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/254433002/diff/20001/src/object-observe.js#newcode83
src/object-observe.js:83: key = %UnwrapGlobalProxy(key);
I'd strongly prefer merging UnwrapGlobalProxy with WeakCollectionGet/Set
in "WeakCollectionGetForObserve", so we don't have a free-floating
runtime function that unwraps global proxies, but keep that behavior
very local to Object.observe.
https://codereview.chromium.org/254433002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/254433002/diff/20001/src/objects.cc#newcode4995
src/objects.cc:4995: if (hash->IsSmi())
Either put on single line or use { }
https://codereview.chromium.org/254433002/diff/20001/src/objects.cc#newcode5021
src/objects.cc:5021: if (hash->IsSmi())
Same as above
https://codereview.chromium.org/254433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
