On 2014/04/28 13:53:31, Jakob wrote:
Any reason you're not looking at both required and observed
representations as
I
suggested? If the only use is e.g. another unary math function (which
requires
double inputs and, being a call, doesn't have any observed
representation), it
would be nice to avoid deopts too. (If in my previous example you use
"function
f(x) { return Math.log(Math.round(x)); }" that should exhibit what I
mean.)
I had misunderstood your first comment. Updated the code to use both
oberved and
required representations, but prefer the observed representation (fixes the
`Math.log(Math.round())` test-case) and also use a double output
representation
for tagged inputs (fixes the `Math.round(x) + "."` test-case).
https://codereview.chromium.org/258793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.