https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js
File test/fuzz-natives/base.js (right):
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode32
test/fuzz-natives/base.js:32: return new Function(args.join(", "),
args.join(", ") == argsStr
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode37
test/fuzz-natives/base.js:37: for (var i = 0; i < 10; i++) {
Should we not better just loop until argc + 1?
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode45
test/fuzz-natives/base.js:45: throw "unexpected exception";
Could we not already "continue" in all other cases where func === null?
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode64
test/fuzz-natives/base.js:64: // When we have 5 or more arguments we
lower the amount of tests cases
...which is always the case.
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode65
test/fuzz-natives/base.js:65: // by randomly removing
kOnManyArgumentsRemove entries
Wouldn't it be better to always choose, 5 instead of removing 5 of 10?
In case somebody extends the list at some point...
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode67
test/fuzz-natives/base.js:67: kArgObjects :
kArgObjects-kOnManyArgumentsRemove;
nit: space around -
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode70
test/fuzz-natives/base.js:70: var rand = Math.floor(Math.random() *
(kArgObjects - i));
Might be easier readable when calling repeatedly argPool.length instead
of (kArgObjects - i)
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode75
test/fuzz-natives/base.js:75: var hasMore = false;
var hasMore exists in the outer scope. Remove var?
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/base.js#newcode77
test/fuzz-natives/base.js:77: for (var i = 0; i < argc; i++) {
Maybe add a TODO about improving the complexity, so that it doesn't
depend anymore on argc or does some other kind of combination like
all-pairs testing...
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/testcfg.py
File test/fuzz-natives/testcfg.py (right):
https://codereview.chromium.org/252143002/diff/20001/test/fuzz-natives/testcfg.py#newcode28
test/fuzz-natives/testcfg.py:28: if output.exit_code != 0:
If the command fails, the test driver would rather quietly pass with no
tests... But no need to do something about that now... I assume in
release mode, the command returns nothing?
https://codereview.chromium.org/252143002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
