LGTM with a nit (which might make sense or not :-)
https://codereview.chromium.org/269353003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/269353003/diff/1/src/hydrogen.cc#newcode5584
src/hydrogen.cc:5584: // Determine field HType from field HeapType.
Does it make sense to extract this into a function HeapType -> HType?
https://codereview.chromium.org/269353003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.