https://codereview.chromium.org/270133003/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/270133003/diff/1/src/bootstrapper.cc#newcode307
src/bootstrapper.cc:307: Handle<JSFunction> throw_type_error_function;
Nit: can we somehow rename this to make it more consistent with the new
one?
https://codereview.chromium.org/270133003/diff/1/src/bootstrapper.cc#newcode1430
src/bootstrapper.cc:1430: Handle<Map> strict_mode_generator_function_map
=
Nit: for consistency, drop _mode_ here, too.
https://codereview.chromium.org/270133003/diff/1/test/mjsunit/harmony/generators-poisoned-properties.js
File test/mjsunit/harmony/generators-poisoned-properties.js (right):
https://codereview.chromium.org/270133003/diff/1/test/mjsunit/harmony/generators-poisoned-properties.js#newcode29
test/mjsunit/harmony/generators-poisoned-properties.js:29: }
This should probably include tests to check the properties while the
respective function is actually active on the call stack.
https://codereview.chromium.org/270133003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
