Revision: 21189
Author: [email protected]
Date: Wed May 7 12:18:23 2014 UTC
Log: Remove GenerateBooleanCheck() since we have a boolean map now.
[email protected]
Review URL: https://codereview.chromium.org/269343003
http://code.google.com/p/v8/source/detail?r=21189
Modified:
/branches/bleeding_edge/src/arm/stub-cache-arm.cc
/branches/bleeding_edge/src/arm64/stub-cache-arm64.cc
/branches/bleeding_edge/src/ia32/stub-cache-ia32.cc
/branches/bleeding_edge/src/mips/stub-cache-mips.cc
/branches/bleeding_edge/src/stub-cache.cc
/branches/bleeding_edge/src/stub-cache.h
/branches/bleeding_edge/src/x64/stub-cache-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/stub-cache-arm.cc Tue Apr 29 06:42:26
2014 UTC
+++ /branches/bleeding_edge/src/arm/stub-cache-arm.cc Wed May 7 12:18:23
2014 UTC
@@ -1165,19 +1165,6 @@
__ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength,
1);
}
}
-
-
-void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
- Label success;
- // Check that the object is a boolean.
- __ LoadRoot(ip, Heap::kTrueValueRootIndex);
- __ cmp(object, ip);
- __ b(eq, &success);
- __ LoadRoot(ip, Heap::kFalseValueRootIndex);
- __ cmp(object, ip);
- __ b(ne, miss);
- __ bind(&success);
-}
Handle<Code> StoreStubCompiler::CompileStoreCallback(
=======================================
--- /branches/bleeding_edge/src/arm64/stub-cache-arm64.cc Tue Apr 29
06:42:26 2014 UTC
+++ /branches/bleeding_edge/src/arm64/stub-cache-arm64.cc Wed May 7
12:18:23 2014 UTC
@@ -1134,19 +1134,6 @@
__ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength,
1);
}
}
-
-
-void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
- UseScratchRegisterScope temps(masm());
- // Check that the object is a boolean.
- Register true_root = temps.AcquireX();
- Register false_root = temps.AcquireX();
- ASSERT(!AreAliased(object, true_root, false_root));
- __ LoadTrueFalseRoots(true_root, false_root);
- __ Cmp(object, true_root);
- __ Ccmp(object, false_root, ZFlag, ne);
- __ B(ne, miss);
-}
Handle<Code> StoreStubCompiler::CompileStoreCallback(
=======================================
--- /branches/bleeding_edge/src/ia32/stub-cache-ia32.cc Wed Apr 30 09:50:58
2014 UTC
+++ /branches/bleeding_edge/src/ia32/stub-cache-ia32.cc Wed May 7 12:18:23
2014 UTC
@@ -1175,17 +1175,6 @@
__ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength,
1);
}
}
-
-
-void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
- Label success;
- // Check that the object is a boolean.
- __ cmp(object, factory()->true_value());
- __ j(equal, &success);
- __ cmp(object, factory()->false_value());
- __ j(not_equal, miss);
- __ bind(&success);
-}
Handle<Code> StoreStubCompiler::CompileStoreCallback(
=======================================
--- /branches/bleeding_edge/src/mips/stub-cache-mips.cc Tue Apr 29 06:42:26
2014 UTC
+++ /branches/bleeding_edge/src/mips/stub-cache-mips.cc Wed May 7 12:18:23
2014 UTC
@@ -1156,17 +1156,6 @@
__ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength,
1);
}
}
-
-
-void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
- Label success;
- // Check that the object is a boolean.
- __ LoadRoot(at, Heap::kTrueValueRootIndex);
- __ Branch(&success, eq, object, Operand(at));
- __ LoadRoot(at, Heap::kFalseValueRootIndex);
- __ Branch(miss, ne, object, Operand(at));
- __ bind(&success);
-}
Handle<Code> StoreStubCompiler::CompileStoreCallback(
=======================================
--- /branches/bleeding_edge/src/stub-cache.cc Tue Apr 29 13:43:17 2014 UTC
+++ /branches/bleeding_edge/src/stub-cache.cc Wed May 7 12:18:23 2014 UTC
@@ -784,9 +784,6 @@
} else if (type->Is(HeapType::Number())) {
function_index = Context::NUMBER_FUNCTION_INDEX;
} else if (type->Is(HeapType::Boolean())) {
- // Booleans use the generic oddball map, so an additional check is
needed to
- // ensure the receiver is really a boolean.
- GenerateBooleanCheck(object_reg, miss);
function_index = Context::BOOLEAN_FUNCTION_INDEX;
} else {
check_type = SKIP_RECEIVER;
=======================================
--- /branches/bleeding_edge/src/stub-cache.h Tue Apr 29 06:42:26 2014 UTC
+++ /branches/bleeding_edge/src/stub-cache.h Wed May 7 12:18:23 2014 UTC
@@ -376,8 +376,6 @@
Label* miss,
PrototypeCheckType check = CHECK_ALL_MAPS);
- void GenerateBooleanCheck(Register object, Label* miss);
-
static void GenerateFastApiCall(MacroAssembler* masm,
const CallOptimization& optimization,
Handle<Map> receiver_map,
=======================================
--- /branches/bleeding_edge/src/x64/stub-cache-x64.cc Tue Apr 29 06:42:26
2014 UTC
+++ /branches/bleeding_edge/src/x64/stub-cache-x64.cc Wed May 7 12:18:23
2014 UTC
@@ -1073,17 +1073,6 @@
__ TailCallExternalReference(ref, StubCache::kInterceptorArgsLength,
1);
}
}
-
-
-void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
- Label success;
- // Check that the object is a boolean.
- __ Cmp(object, factory()->true_value());
- __ j(equal, &success);
- __ Cmp(object, factory()->false_value());
- __ j(not_equal, miss);
- __ bind(&success);
-}
Handle<Code> StoreStubCompiler::CompileStoreCallback(
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
