Reviewers: Michael Starzinger, Toon Verwaest,
Message:
Hi Michael (and Toon if you want to have a look),
Here is the fix. As discussed, I would like to move this under
JSObject::SetLocalPropertyIgnoreAttributes, rather than keeping the special
case
in the runtime function. But I'm inclined to do that as a follow-up.
Thanks,
--Michael
Description:
Changing the attributes of a data property implemented with
ExecutableAccessorInfo turns the property into a field. Better
to keep it as a callback, and correctly deal with the changed
property attributes.
Please review this at https://codereview.chromium.org/262053011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+126, -15 lines):
M src/accessors.h
M src/accessors.cc
M src/objects.h
M src/objects.cc
M src/objects-inl.h
M src/runtime.cc
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
