LGTM if the comments are addressed *or* if they are handled in separate
CL(s).
https://codereview.chromium.org/275433004/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (left):
https://codereview.chromium.org/275433004/diff/1/src/ia32/assembler-ia32.h#oldcode234
src/ia32/assembler-ia32.h:234: struct X87Register : IntelDoubleRegister
{
I think we can nuke/merge IntelDoubleRegister/DoubleRegister now, there
is only a single kind of double registers now.
https://codereview.chromium.org/275433004/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/275433004/diff/1/src/ia32/code-stubs-ia32.cc#newcode4308
src/ia32/code-stubs-ia32.cc:4308: bool CodeStub::CanUseFPRegisters() {
We can nuke CanUseFPRegisters, it is always true on all platforms now.
https://codereview.chromium.org/275433004/diff/1/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):
https://codereview.chromium.org/275433004/diff/1/src/ia32/deoptimizer-ia32.cc#newcode234
src/ia32/deoptimizer-ia32.cc:234: return
isolate_->builtins()->builtin(Builtins::kNotifyStubFailureSaveDoubles);
I think we always use kNotifyStubFailureSaveDoubles, so the constants
and the parameter can be nuked.
https://codereview.chromium.org/275433004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
