Reviewers: Michael Achenbach,
Message:
PTAL, thx!
Description:
Commenting out an assert to investigate mac test failure.
[email protected]
Please review this at https://codereview.chromium.org/268363010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -2 lines):
M src/utils.h
Index: src/utils.h
diff --git a/src/utils.h b/src/utils.h
index
8de0d3e50c2999070997218d7389be0d8e10e20f..115f7847584d07d7b476131dc44de4181e14ba61
100644
--- a/src/utils.h
+++ b/src/utils.h
@@ -1133,8 +1133,11 @@ inline Vector< Handle<Object> >
HandleVector(v8::internal::Handle<T>* elms,
template <typename T>
inline void CopyWords(T* dst, const T* src, size_t num_words) {
STATIC_ASSERT(sizeof(T) == kPointerSize);
- ASSERT(Min(dst, const_cast<T*>(src)) + num_words <=
- Max(dst, const_cast<T*>(src)));
+ // TODO(mvstanton): disabled because mac builds are bogus failing on this
+ // assert. They are doing a signed comparison. Investigate in
+ // the morning.
+ // ASSERT(Min(dst, const_cast<T*>(src)) + num_words <=
+ // Max(dst, const_cast<T*>(src)));
ASSERT(num_words > 0);
// Use block copying OS::MemCopy if the segment we're copying is
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
