I am looking into debug-multiple-breakpoints.js failure.
https://codereview.chromium.org/271543004/diff/40001/src/arm64/macro-assembler-arm64-inl.h
File src/arm64/macro-assembler-arm64-inl.h (right):
https://codereview.chromium.org/271543004/diff/40001/src/arm64/macro-assembler-arm64-inl.h#newcode1253
src/arm64/macro-assembler-arm64-inl.h:1253: Sub(temp, StackPointer(),
space);
What was the bug here?
https://codereview.chromium.org/271543004/diff/40001/src/arm64/macro-assembler-arm64.h
File src/arm64/macro-assembler-arm64.h (right):
https://codereview.chromium.org/271543004/diff/40001/src/arm64/macro-assembler-arm64.h#newcode726
src/arm64/macro-assembler-arm64.h:726: void AssertStackConsistency(bool
csp_was_modified);
Nit: we usually pass flags as enums with descriptive names, that
improves readability at call-sites.
https://codereview.chromium.org/271543004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
