https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py
File tools/generate-runtime-tests.py (right):
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode20
tools/generate-runtime-tests.py:20: BASEPATH = os.path.join(WORKSPACE,
"test", "mjsunit", "runtime-gen")
On 2014/05/08 08:03:12, Michael Achenbach wrote:
Wouldn't this fit better into the fuzz-natives test suite?
Semantically yes, but the distinction between mjsunit and fuzz-natives
is based on what testcfg.py needs to do (how test cases are found and
executed), and from that point of view these generated tests fall
squarely into mjsunit territory.
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode193
tools/generate-runtime-tests.py:193: self.ArgCtor = ctor
On 2014/05/08 08:03:12, Michael Achenbach wrote:
nit: lower case?
Chose upper case since this isn't just a field, it's a dynamically bound
non-featherweight function. (See the call in line 2260).
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode408
tools/generate-runtime-tests.py:408: if i > 0: call += ", "
On 2014/05/08 08:03:12, Michael Achenbach wrote:
how about collecting the names in a list and then defining call
afterwards as:
call = "%%%s%s(%s)" % (f.inline, f.name, ", ".join(arg_names))
I've already refactored this in a follow-up CL that's sitting on my hard
disk.
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode450
tools/generate-runtime-tests.py:450: functions = FindRuntimeFunctions()
On 2014/05/08 08:03:12, Michael Achenbach wrote:
Would it be useful if it found also functions defined in extensions
(like free
buffer)?
Potentially. This is just a first step. There is plenty of room for
future improvement.
https://codereview.chromium.org/250923002/diff/20001/tools/generate-runtime-tests.py#newcode487
tools/generate-runtime-tests.py:487: files = os.listdir(BASEPATH)
On 2014/05/08 08:03:12, Michael Achenbach wrote:
Wonder if there appears a .svn folder on the bots here, once this is
committed?
Good point. Let's filter out dotfiles.
https://codereview.chromium.org/250923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
