LGTM. Out of curiosity why we need to use macro-assembler Sub() in
BumpSystemStackPointer?
Otherwise if the Operand is an immediate which is !uint_12, then the sub()
operation will fail with an Assert.
https://codereview.chromium.org/271543004/diff/80001/src/arm64/macro-assembler-arm64.cc
File src/arm64/macro-assembler-arm64.cc (right):
https://codereview.chromium.org/271543004/diff/80001/src/arm64/macro-assembler-arm64.cc#newcode1191
src/arm64/macro-assembler-arm64.cc:1191: if (emit_debug_code() &&
use_real_aborts()) {
On 2014/05/08 14:01:48, jbramley wrote:
I think a comment is in order.
Done.
https://codereview.chromium.org/271543004/diff/80001/src/arm64/macro-assembler-arm64.cc#newcode1207
src/arm64/macro-assembler-arm64.cc:1207: { DontEmitDebugCodeScope
dont_emit_debug_code_scope(this);
On 2014/05/08 14:01:48, jbramley wrote:
Ditto.
Done.
https://codereview.chromium.org/271543004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
