lgtm.
https://codereview.chromium.org/286203010/diff/1/src/regexp.js
File src/regexp.js (right):
https://codereview.chromium.org/286203010/diff/1/src/regexp.js#newcode114
src/regexp.js:114: macro BuildResultFromMatchInfo(MATCHINFO, STRING)
I would use capital naming for the macro to make it clear at call sites
that it's a macro.
https://codereview.chromium.org/286203010/diff/1/src/regexp.js#newcode138
src/regexp.js:138: return result;
Why not make this part of the macro and call it something like
RETURN_NEW_RESULT_FROM_MATCH_INFO.
https://codereview.chromium.org/286203010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
