Reviewers: Sven Panne,
Message:
PTAL
Description:
Drop redundant FullCodeGenerator::prepared_bailout_ids_.
Please review this at https://codereview.chromium.org/294543002/
SVN Base: [email protected]:v8/v8.git@master
Affected files (+5, -3 lines):
M src/full-codegen.h
M src/full-codegen.cc
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index
7db8a5680edaf27e49fcff5a3c8239d635951392..6ae927c9018a16a5462f2448f5ae79bdc3e997a1
100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -452,9 +452,12 @@ void
FullCodeGenerator::PrepareForBailoutForId(BailoutId id, State state) {
unsigned pc_and_state =
StateField::encode(state) | PcField::encode(masm_->pc_offset());
ASSERT(Smi::IsValid(pc_and_state));
+#ifdef DEBUG
+ for (int i = 0; i < bailout_entries_.length(); ++i) {
+ ASSERT(bailout_entries_[i].id != id);
+ }
+#endif
BailoutEntry entry = { id, pc_and_state };
- ASSERT(!prepared_bailout_ids_.Contains(id.ToInt()));
- prepared_bailout_ids_.Add(id.ToInt(), zone());
bailout_entries_.Add(entry, zone());
}
Index: src/full-codegen.h
diff --git a/src/full-codegen.h b/src/full-codegen.h
index
44dd9b19728794efb42e99b2fd081054aa2fa90f..148d0c02de2736cc27149e3b6c2be654ffdd86d9
100644
--- a/src/full-codegen.h
+++ b/src/full-codegen.h
@@ -820,7 +820,6 @@ class FullCodeGenerator: public AstVisitor {
int module_index_;
const ExpressionContext* context_;
ZoneList<BailoutEntry> bailout_entries_;
- GrowableBitVector prepared_bailout_ids_;
ZoneList<BackEdgeEntry> back_edges_;
int ic_total_count_;
Handle<FixedArray> handler_table_;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
