[v8-dev] Remove unused thread locals from debugger. (issue 286903003)

Tue, 20 May 2014 05:15:30 -0700 

Reviewers: ulan,

Description:
Remove unused thread locals from debugger.

[email protected]

Please review this at https://codereview.chromium.org/286903003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+1, -23 lines):
  M src/arm/frames-arm.h
  M src/arm64/frames-arm64.h
  M src/debug.h
  M src/debug.cc
  M src/ia32/frames-ia32.h
  M src/mips/frames-mips.h
  M src/x64/frames-x64.h


Index: src/arm/frames-arm.h
diff --git a/src/arm/frames-arm.h b/src/arm/frames-arm.h
index 6dd5186404e6b0d4cd0fc5fa7bcdf5ef91bc8367..ce65e887f84aec811648f27e0253b934e1fb89d6 100644 
--- a/src/arm/frames-arm.h
+++ b/src/arm/frames-arm.h
@@ -29,8 +29,6 @@ const RegList kJSCallerSaved =

 const int kNumJSCallerSaved = 4;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-
// Return the code of the n-th caller-saved register available to JavaScript 
 // e.g. JSCallerSavedReg(0) returns r0.code() == 0
 int JSCallerSavedCode(int n);
Index: src/arm64/frames-arm64.h
diff --git a/src/arm64/frames-arm64.h b/src/arm64/frames-arm64.h
index 3996bd75dc9524465251218a4bcf7a2197db859c..7ac274a22efe9b625ba2d5b308df71f2277f34bf 100644 
--- a/src/arm64/frames-arm64.h
+++ b/src/arm64/frames-arm64.h
@@ -15,7 +15,6 @@ const int kNumRegs = kNumberOfRegisters;
 // Registers x0-x17 are caller-saved.
 const int kNumJSCallerSaved = 18;
 const RegList kJSCallerSaved = 0x3ffff;
-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];

 // Number of registers for which space is reserved in safepoints. Must be a
 // multiple of eight.
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index a994eb008511c44574ade6986d6463ea53f1c70e..b13a1631573b2aa3db7bb26e4a302bcc9317ce72 100644 
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -40,7 +40,6 @@ Debug::Debug(Isolate* isolate)
       promise_catch_handlers_(0),
       promise_getters_(0),
       isolate_(isolate) {
-  memset(registers_, 0, sizeof(JSCallerSavedBuffer));
   ThreadInit();
 }

@@ -518,10 +517,7 @@ void Debug::ThreadInit() {
 char* Debug::ArchiveDebug(char* storage) {
   char* to = storage;
OS::MemCopy(to, reinterpret_cast<char*>(&thread_local_), sizeof(ThreadLocal)); 
-  to += sizeof(ThreadLocal);
- OS::MemCopy(to, reinterpret_cast<char*>(&registers_), sizeof(registers_)); 
   ThreadInit();
-  ASSERT(to <= storage + ArchiveSpacePerThread());
   return storage + ArchiveSpacePerThread();
 }

@@ -530,15 +526,12 @@ char* Debug::RestoreDebug(char* storage) {
   char* from = storage;
   OS::MemCopy(
       reinterpret_cast<char*>(&thread_local_), from, sizeof(ThreadLocal));
-  from += sizeof(ThreadLocal);
- OS::MemCopy(reinterpret_cast<char*>(&registers_), from, sizeof(registers_)); 
-  ASSERT(from <= storage + ArchiveSpacePerThread());
   return storage + ArchiveSpacePerThread();
 }


 int Debug::ArchiveSpacePerThread() {
-  return sizeof(ThreadLocal) + sizeof(JSCallerSavedBuffer);
+  return sizeof(ThreadLocal);
 }


Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index 80e6970e34caccbceb0d0f499443b9b6f7bd1dc2..9a110475dc9dfb3c95d7b2913de8189588a196d1 100644 
--- a/src/debug.h
+++ b/src/debug.h
@@ -350,11 +350,6 @@ class Debug {
     return reinterpret_cast<Address*>(address);
   }
- // Support for saving/restoring registers when handling debug break calls. 
-  Object** register_address(int r) {
-    return &registers_[r];
-  }
-
   static const int kEstimatedNofDebugInfoEntries = 16;
   static const int kEstimatedNofBreakPointsInFunction = 16;

@@ -586,7 +581,6 @@ class Debug {
   };

   // Storage location for registers when handling debug break calls
-  JSCallerSavedBuffer registers_;
   ThreadLocal thread_local_;
   void ThreadInit();

Index: src/ia32/frames-ia32.h
diff --git a/src/ia32/frames-ia32.h b/src/ia32/frames-ia32.h
index fcfabda8b6b23bf964d74d87a37846563649b9a5..1290ad6e09ddf8ffdca3c2cdfab601e143cc86fa 100644 
--- a/src/ia32/frames-ia32.h
+++ b/src/ia32/frames-ia32.h
@@ -24,8 +24,6 @@ const RegList kJSCallerSaved =

 const int kNumJSCallerSaved = 5;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-

 // Number of registers for which space is reserved in safepoints.
 const int kNumSafepointRegisters = 8;
Index: src/mips/frames-mips.h
diff --git a/src/mips/frames-mips.h b/src/mips/frames-mips.h
index c7b88aa5ccedafb2e71a1a0c2ba1ffe45eab45a6..5666f642f99938879cab6251f36ef901434350bd 100644 
--- a/src/mips/frames-mips.h
+++ b/src/mips/frames-mips.h
@@ -87,8 +87,6 @@ const RegList kSafepointSavedRegisters = kJSCallerSaved | kCalleeSaved; 
 const int kNumSafepointSavedRegisters =
     kNumJSCallerSaved + kNumCalleeSaved;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-
 const int kUndefIndex = -1;
 // Map with indexes on stack that corresponds to codes of saved registers.
 const int kSafepointRegisterStackIndexMap[kNumRegs] = {
Index: src/x64/frames-x64.h
diff --git a/src/x64/frames-x64.h b/src/x64/frames-x64.h
index 43c11961c36723fdc4f1ffef8d76b06619e9142e..88130302849530302f66a3ac7105226e7c63d052 100644 
--- a/src/x64/frames-x64.h
+++ b/src/x64/frames-x64.h
@@ -18,8 +18,6 @@ const RegList kJSCallerSaved =

 const int kNumJSCallerSaved = 5;

-typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
-
 // Number of registers for which space is reserved in safepoints.
 const int kNumSafepointRegisters = 16;



--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to