Reviewers: Michael Starzinger,
https://codereview.chromium.org/297663008/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/297663008/diff/1/src/heap.cc#newcode5055
src/heap.cc:5055: // to avoid that resource-constrained embedders run
out of memory.
On 2014/05/21 12:40:59, Michael Starzinger wrote:
nit: s/out of memory/low on memory/
Done.
Description:
Increase external allocation limit.
BUG=
Please review this at https://codereview.chromium.org/297663008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -3 lines):
M src/heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
b672bbffbb811966d292580abca673257041dd9b..165cc8055796def139b520b612c8c119f3224e68
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -5052,9 +5052,8 @@ bool Heap::ConfigureHeap(int max_semi_space_size,
initial_semispace_size_ = Min(initial_semispace_size_,
max_semi_space_size_);
// The external allocation limit should be below 256 MB on all
architectures
- // to avoid unnecessary low memory notifications, as that is the
threshold
- // for some embedders.
- external_allocation_limit_ = 12 * max_semi_space_size_;
+ // to avoid that resource-constrained embedders run low on memory.
+ external_allocation_limit_ = 24 * max_semi_space_size_;
ASSERT(external_allocation_limit_ <= 256 * MB);
// The old generation is paged and needs at least one page for each
space.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
