LGTM wit nits.
https://codereview.chromium.org/279423005/diff/40001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/279423005/diff/40001/src/arm/code-stubs-arm.cc#newcode3125
src/arm/code-stubs-arm.cc:3125: // the MONOMORPHIC_ARRAY case is handled
with a helper function.
nit: this comment is a bit misleading, all non-defaults are handled with
a helper function, MONOMORPHIC_ARRAY is just an example.
https://codereview.chromium.org/279423005/diff/40001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/279423005/diff/40001/src/ic.cc#newcode512
src/ic.cc:512: return;
nit: you don't need the return at the end.
https://codereview.chromium.org/279423005/diff/40001/src/ic.cc#newcode1850
src/ic.cc:1850:
isolate()->context()->native_context()->array_function(),
nit: strange indentations
https://codereview.chromium.org/279423005/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/279423005/diff/40001/src/objects.cc#newcode11241
src/objects.cc:11241: case ALLOCATION_SITE_TYPE: break;
Perhaps comments here explaining why each of these cases shouldn't clear
feedback?
https://codereview.chromium.org/279423005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
