Yes, all platforms have the same changes.

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newcode843
src/arm/lithium-arm.cc:843: void
LChunkBuilder::CheckAndAddInstruction(LInstruction* instr,
On 2014/05/22 12:59:46, Jakob wrote:
I'd call this just AddInstruction...

Done.

https://codereview.chromium.org/296993002/diff/1/src/arm/lithium-arm.cc#newcode845
src/arm/lithium-arm.cc:845: if (instr != NULL) {
On 2014/05/22 12:59:46, Jakob wrote:
...and move this check to the caller. I don't think other callers need
the
flexibility to pass in NULL.

Done.

https://codereview.chromium.org/296993002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to