LGTM with comment.
https://codereview.chromium.org/307553003/diff/1/tools/testrunner/local/execution.py
File tools/testrunner/local/execution.py (right):
https://codereview.chromium.org/307553003/diff/1/tools/testrunner/local/execution.py#newcode68
tools/testrunner/local/execution.py:68: if not context.no_sorting:
As discussed, a better implementation might be to leave this line
untouched...
https://codereview.chromium.org/307553003/diff/1/tools/testrunner/local/execution.py#newcode98
tools/testrunner/local/execution.py:98: for test in sorted(self.tests,
key=lambda t: t.duration, reverse=True):
...and instead do here:
if not self.context.no_sorting:
self.tests = sorted(self.tests, key=lambda t: t.duration,
reverse=True)
for test in self.tests:
...
https://codereview.chromium.org/307553003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
