Reviewers: dcarney,
Message:
PTAL. This will require a tiny change on the blink side, which can land
before
this CL lands.
Description:
Remove PROHIBITS_OVERWRITING as it is subsumed by non-configurable
properties.
v8::DontDelete is set for Unforgeable properties, so just not setting
PROHIBITS_OVERWRITING should be enough.
The secondary "feature" of not allowing accessors to be installed in
extending
objects is incorrect and confusing, given that it only applies to accessors
but
not to regular properties:
Object.defineProperty({__proto__:window}, "location", { value: 10 })
works where
Object.defineProperty({__proto__:window}, "location", { get: function() {}
})
doesn't work.
LOG=y
Please review this at https://codereview.chromium.org/306203002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -130 lines):
M include/v8.h
M src/accessors.cc
M src/api.cc
M src/objects.h
M src/objects.cc
M src/objects-inl.h
M test/cctest/test-accessors.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
