Ended up requiring was_present in both Remove methods and updated runtime
to use
that instead of the extra Lookup.
https://codereview.chromium.org/309663005/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/309663005/diff/20001/src/objects.h#newcode4219
src/objects.h:4219: static Handle<Derived> Remove(Handle<Derived> table,
Handle<Object> key);
On 2014/05/30 20:13:58, adamk wrote:
I'm not sure you need this anywhere after you update runtime.cc for my
comments.
Done.
https://codereview.chromium.org/309663005/diff/20001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/309663005/diff/20001/src/runtime.cc#newcode1646
src/runtime.cc:1646: Handle<OrderedHashMap> new_table =
OrderedHashMap::Remove(table, key);
On 2014/05/30 20:13:58, adamk wrote:
You probably want to use the was_present version here, which will
allow you to
remove the lookup call on the line above.
Done.
https://codereview.chromium.org/309663005/diff/20001/test/cctest/test-ordered-hash-table.cc
File test/cctest/test-ordered-hash-table.cc (right):
https://codereview.chromium.org/309663005/diff/20001/test/cctest/test-ordered-hash-table.cc#newcode179
test/cctest/test-ordered-hash-table.cc:179: ordered_map =
OrderedHashMap::Remove(ordered_map, obj);
On 2014/05/30 20:13:58, adamk wrote:
Probably want to test the was_present version as well...
Done.
https://codereview.chromium.org/309663005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
