Revision: 21590
Author: yang...@chromium.org
Date: Mon Jun 2 06:22:09 2014 UTC
Log: Remove unused debug API.
R=yu...@chromium.org
Review URL: https://codereview.chromium.org/303693010
http://code.google.com/p/v8/source/detail?r=21590
Modified:
/branches/bleeding_edge/include/v8-debug.h
/branches/bleeding_edge/src/debug.cc
/branches/bleeding_edge/test/cctest/test-debug.cc
=======================================
--- /branches/bleeding_edge/include/v8-debug.h Wed May 14 16:28:46 2014 UTC
+++ /branches/bleeding_edge/include/v8-debug.h Mon Jun 2 06:22:09 2014 UTC
@@ -139,9 +139,6 @@
*/
typedef void (*EventCallback)(const EventDetails& event_details);
- // TODO(yangguo) Deprecate this.
- typedef EventCallback EventCallback2;
-
/**
* Debug message callback function.
*
@@ -152,9 +149,6 @@
*/
typedef void (*MessageHandler)(const Message& message);
- // TODO(yangguo) Deprecate this.
- typedef MessageHandler MessageHandler2;
-
/**
* Callback function for the host to ensure debug messages are processed.
*/
@@ -162,12 +156,6 @@
static bool SetDebugEventListener(EventCallback that,
Handle<Value> data = Handle<Value>());
-
- // TODO(yangguo) Deprecate this.
- static bool SetDebugEventListener2(EventCallback2 that,
- Handle<Value> data = Handle<Value>())
{
- return SetDebugEventListener(that, data);
- }
// Schedule a debugger break to happen when JavaScript code is run
// in the given isolate.
@@ -191,11 +179,6 @@
// Message based interface. The message protocol is JSON.
static void SetMessageHandler(MessageHandler handler);
-
- // TODO(yangguo) Deprecate this.
- static void SetMessageHandler2(MessageHandler2 handler) {
- SetMessageHandler(handler);
- }
static void SendCommand(Isolate* isolate,
const uint16_t* command, int length,
=======================================
--- /branches/bleeding_edge/src/debug.cc Wed May 28 10:41:13 2014 UTC
+++ /branches/bleeding_edge/src/debug.cc Mon Jun 2 06:22:09 2014 UTC
@@ -2864,8 +2864,8 @@
Handle<Object> event_data,
v8::Debug::ClientData* client_data) {
Handle<Foreign> callback_obj(Handle<Foreign>::cast(event_listener_));
- v8::Debug::EventCallback2 callback =
- FUNCTION_CAST<v8::Debug::EventCallback2>(
+ v8::Debug::EventCallback callback =
+ FUNCTION_CAST<v8::Debug::EventCallback>(
callback_obj->foreign_address());
EventDetailsImpl event_details(
event,
=======================================
--- /branches/bleeding_edge/test/cctest/test-debug.cc Tue May 27 13:43:29
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-debug.cc Mon Jun 2 06:22:09
2014 UTC
@@ -6647,7 +6647,7 @@
counting_message_handler_counter = 0;
- v8::Debug::SetMessageHandler2(CountingMessageHandler);
+ v8::Debug::SetMessageHandler(CountingMessageHandler);
send_command_thread_ = new SendCommandThread(isolate);
send_command_thread_->Start();
@@ -6659,7 +6659,7 @@
CHECK_EQ(100, counting_message_handler_counter);
- v8::Debug::SetMessageHandler2(NULL);
+ v8::Debug::SetMessageHandler(NULL);
CheckDebuggerUnloaded();
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
