Hi Benedikt, very nice. Just one stylistic comment.
--Michael
https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc#newcode8063
src/hydrogen.cc:8063: {
How about put this in a function, BuildArrayIndexOf(id, search_element,
receiver, ..)
https://codereview.chromium.org/308793012/diff/1/src/hydrogen.cc#newcode8164
src/hydrogen.cc:8164: }
function ends here, postcondition being that in non-effect context the
result is on the top of the environment stack.
https://codereview.chromium.org/308793012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
