LGTM, but the test case can be a *lot* simpler. Something like
Flags: --nouse-osr
function f() {
%OptimizeFunctionOnNextCall(f, "osr");
for (var i = 0; i < 1000; i++);
}
f();
https://codereview.chromium.org/310773003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/310773003/diff/1/src/runtime.cc#newcode8718
src/runtime.cc:8718: ASSERT(FLAG_use_osr);
RUNTIME_ASSERT is more appropriate.
https://codereview.chromium.org/310773003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.