Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Remove duplicate code in SetPropertyPostInterceptor
BUG=
Please review this at https://codereview.chromium.org/314673002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -16 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
1a63712ee9d9e1c673f77e13447e9f69214571fb..82d26be01426969293366e7bcf73fc022e7ef059
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2081,22 +2081,8 @@ MaybeHandle<Object>
JSObject::SetPropertyPostInterceptor(
if (!result.IsFound()) {
object->map()->LookupTransition(*object, *name, &result);
}
- if (result.IsFound()) {
- // An existing property or a map transition was found. Use set
property to
- // handle all these cases.
- return SetPropertyForResult(object, &result, name, value, attributes,
- strict_mode, MAY_BE_STORE_FROM_KEYED);
- }
- bool done = false;
- Handle<Object> result_object;
- ASSIGN_RETURN_ON_EXCEPTION(
- isolate, result_object,
- SetPropertyViaPrototypes(
- object, name, value, attributes, strict_mode, &done),
- Object);
- if (done) return result_object;
- // Add a new real property.
- return AddProperty(object, name, value, attributes, strict_mode);
+ return SetPropertyForResult(object, &result, name, value, attributes,
+ strict_mode, MAY_BE_STORE_FROM_KEYED);
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
