https://codereview.chromium.org/301973014/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/301973014/diff/1/src/hydrogen-instructions.cc#newcode3837
src/hydrogen-instructions.cc:3837: HConstant*
new_dominator_size_upper_bound_c =
I don't like the _c, can we have a proper name?
Moreover, the size variable names are very confusing and inconsistent.
Can we clean that up?
I think the start point is good:
dominator_size is the dominator size instruction, the new dominator size
instruction should be called new_dominator_size. When we take the int
value of a constant size instruction it could be called
dominator_size_value...
https://codereview.chromium.org/301973014/diff/1/src/hydrogen-instructions.cc#newcode4047
src/hydrogen-instructions.cc:4047: clear_next_map->InsertAfter(this);
Can you move
clear_next_map->ClearAllSideEffects();
clear_next_map->InsertAfter(this);
after the else case?
https://codereview.chromium.org/301973014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
