https://codereview.chromium.org/310393003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/310393003/diff/1/include/v8.h#newcode6614
include/v8.h:6614: 192 * 1024 * 1024) {
On 2014/06/04 11:24:49, Hannes Payer wrote:
192? Please don't use a hard-coded value here.
Done.
https://codereview.chromium.org/310393003/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/310393003/diff/1/src/heap-inl.h#newcode544
src/heap-inl.h:544: if (amount_since_last_global_gc > 192 * MB) {
On 2014/06/04 11:24:49, Hannes Payer wrote:
192?
external_allocation_limit_ is hard-coded to 192MB, I moved this to v8.h
https://codereview.chromium.org/310393003/diff/1/src/heap.h
File src/heap.h (left):
https://codereview.chromium.org/310393003/diff/1/src/heap.h#oldcode1041
src/heap.h:1041: inline int64_t AdjustAmountOfExternalAllocatedMemory(
On 2014/06/04 11:24:49, Hannes Payer wrote:
With that change, can we get rid of this method? The array buffers
could use the
new method.
The fast path method doesn't handle the case where we need to GC
https://codereview.chromium.org/310393003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
