On 2014/06/04 11:00:09, Jakob wrote:
LGTM if you add a test that exercises this code path. (No need to assert
directly that BCE did something, just check that we computed the right
result.
Try to create a challenge for the algorithm, e.g. a situation where a
bounds
check should fail, and/or where several basic blocks are involved, and/or
mix
HAdd and HConstant indices.)
Added a bunch of test cases as suggested.
https://codereview.chromium.org/310333004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
